Skip to content

fix: dex loader parent injection release vs debug #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NathanWalker wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

fix: dex loader parent injection release vs debug #1964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion test-app/runtime/src/main/java/com/tns/Runtime.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,7 +766,13 @@ private void init(Logger logger, String appName, String nativeLibDir, File rootD
this.logger = logger;

boolean isMainThread = this.workerId == 0;
this.dexFactory = new DexFactory(logger, classLoader, dexDir, dexThumb, classStorageService, isMainThread);
// Parent-classloader injection is for debug/HMR cases where generated
// classes must be visible to framework reflection. In release, keep
// runtime-generated proxies in their isolated DexClassLoader; injecting
// through a temporary DexClassLoader can make ART reject the same dex
// path as registered by multiple class loaders.
boolean injectIntoParentClassLoader = isMainThread && isDebuggable;
this.dexFactory = new DexFactory(logger, classLoader, dexDir, dexThumb, classStorageService, injectIntoParentClassLoader);

if (logger.isEnabled()) {
logger.write("Initializing NativeScript JAVA");
Expand Down
Loading