chore: import napi-android history#44
Conversation
Update V8 to 13.8.9
hermes: support loading bytecode
Add global unhandled promise rejection handling
quickjs: support multiple quickjs versions
We need to ensure the errors created via public API JS_NewError include .stack property.
Fix quickjs bugs
fix console.log(error) should include stack trace
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ammarahm-ed
left a comment
There was a problem hiding this comment.
Everything in the folder `platforms/android/test-app/app/src/main/assets/app/shared folder is not needed since those tests and files are shared across iOS and Android I think in the original android/ios runtimes. At the time when I was writing the runtimes I didn't make the effort to use gitmodules and link it properly and just copied it over. I think we can find a way around this since the shared folder is imported from JS on android and the imports are relative to current script dir. Maybe we can have a script that will copy the files over from a common place on android and ios as needed.
ammarahm-ed
left a comment
There was a problem hiding this comment.
The github workflows are outdated and we probably want to replace them with something better that builds with all engines. Either we remove these and address this later or do it now.
ammarahm-ed
left a comment
There was a problem hiding this comment.
Remove .vscode and .idea folders.
There was a problem hiding this comment.
Remove this file and related code in MainActivity.js to run benchmark.
There was a problem hiding this comment.
We probably don't need to commit node_modules.
What changed
Imports the
NativeScript/napi-androidmainbranch history into this repository underplatforms/android/, preserving the Android commit topology after rewriting paths for monorepo placement.The import adds a root
.gitattributesentry for Android V8 monolith archives and stores those archives with Git LFS so the branch can be pushed to GitHub without regular Git blobs over 100 MB.Why
This creates the first clean history-preserving layer for turning the runtime repository into a monorepo that can host iOS/macOS/Android in one place, with room for future Linux and Windows runtime work.
Validation
origin/refactoras its merge base.origin/refactor.platforms/android/contains 10,230 files at HEAD.git log --follow -- platforms/android/README.mdtraverses imported Android history.git fsck --connectivity-only; it completed successfully. Dangling objects reported are from local scratch rewrites and are not referenced by the pushed branch.