Skip to content

fix(precompute): cms_params() rejects planner-emitted depth/width params for CountMinSketch #482

Description

@milindsrivastava1997

Sub-issue of #477 (defect 1 only).

Problem

cms_params() in accumulator_factory.rs only reads row_num/col_num, but the planner (sketch.rs) emits depth/width for CountMinSketch. Every plain-CMS aggregation throws:

WARN ... CMS config missing required parameter: row_num

and never ingests. Regression from #397, which made params required without adding the depth/width alias on this path.

cms_heap_params() (for CountMinSketchWithHeap) already accepts depth/width first — the fix is to mirror that pattern in cms_params().

Fix

In cms_params(), try depth/width before row_num/col_num (matching cms_heap_params()).

Metadata

Metadata

Labels

bugSomething isn't working

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions