fix: keep devcontainer setup running after Kiro failure#2864
Open
wondr-wclabs wants to merge 1 commit into
Open
fix: keep devcontainer setup running after Kiro failure#2864wondr-wclabs wants to merge 1 commit into
wondr-wclabs wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the devcontainer bootstrap more resilient by ensuring a transient failure downloading/installing Kiro CLI (e.g., upstream 404) doesn’t abort the rest of .devcontainer/post-create.sh, so subsequent tooling (Kimi, CodeBuddy, uv, DocFx) still installs.
Changes:
- Added a non-fatal command wrapper (
run_optional_command) and applied it to the Kiro install + verification flow while keeping other installs fatal. - Added a regression test to assert the Kiro block uses the optional wrapper, avoids direct
exit 1, and explicitly indicates setup will continue.
Show a summary per file
| File | Description |
|---|---|
.devcontainer/post-create.sh |
Introduces run_optional_command and makes the Kiro installation path non-blocking while preserving checksum verification when available. |
tests/test_agent_config_consistency.py |
Adds a regression check to ensure the Kiro block remains non-blocking and advertises continued setup. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
Comment on lines
+24
to
+25
| # Function to run an optional command and continue on error | ||
| run_optional_command() { |
| fi | ||
| } | ||
|
|
||
| # Function to run an optional command and continue on error |
Comment on lines
+34
to
+36
| echo -e "\033[0;33m[WARN] Optional command failed (Exit Code $exit_code): $command_to_run\033[0m" >&2 | ||
| echo -e "\033[0;33m$output\033[0m" >&2 | ||
| return $exit_code |
| )[0] | ||
|
|
||
| assert "run_optional_command" in kiro_block | ||
| assert "exit 1" not in kiro_block |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2605.
The devcontainer
post-create.shscript used the fatalrun_commandwrapper for every Kiro installer step. When the upstream Kiro installer URL returns 404, that exits the whole post-create script and prevents later tools from installing, including Kimi CLI, CodeBuddy, uv, and DocFx.This keeps the pinned Kiro installer checksum verification in place when the installer is available, but makes the Kiro block non-blocking:
run_optional_commandfor installer steps that should warn and continue;exit 1and advertises continued setup.The reason for limiting the optional behavior to Kiro is that #2605 is caused by one unavailable optional upstream installer. Making every devcontainer install non-fatal would hide real setup failures for core tooling.
Validation
bash -n .devcontainer/post-create.shuv run python -m pytest tests/test_agent_config_consistency.py -q— 30 passeduv run python -m pytest tests/integrations/test_integration_kiro_cli.py tests/test_agent_config_consistency.py -q— 55 passedgit diff --checkuv run python -m pytest -q— 3576 passed, 45 skippedAI assistance disclosure
This PR was developed with AI assistance from Codex/ChatGPT for codebase inspection, implementation, and validation. I reviewed the diff and test output before submitting.