Skip to content

Revert back to v4 behavior for group registering implicit 404 handler…#2996

Open
aldas wants to merge 3 commits into
labstack:masterfrom
aldas:revert_to_v4_group_404_implicit_handlers
Open

Revert back to v4 behavior for group registering implicit 404 handler…#2996
aldas wants to merge 3 commits into
labstack:masterfrom
aldas:revert_to_v4_group_404_implicit_handlers

Conversation

@aldas

@aldas aldas commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

FIX: #2950

Revert back to v4 behavior for group registering implicit 404 handlers. This will fix: CORS middleware doesnt automatically handle OPTIONS routes for groups anymore since upgrade to v5.

This is a breaking change in v5. It reverts back to v4 behavior.

aldas added 2 commits June 8, 2026 22:49
…s. This will fix: CORS middleware doesnt automatically handle OPTIONS routes for groups anymore since upgrade to v5
@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.20%. Comparing base (01b45be) to head (662f4d0).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
router.go 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2996      +/-   ##
==========================================
+ Coverage   93.17%   93.20%   +0.02%     
==========================================
  Files          43       43              
  Lines        4501     4517      +16     
==========================================
+ Hits         4194     4210      +16     
- Misses        189      190       +1     
+ Partials      118      117       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CORS middleware doesnt automatically handle OPTIONS routes for groups anymore since upgrade to v5

1 participant