Migrate to ESLint 10 (flat config), @typescript-eslint v8, TypeScript 5.9, @types/node 22#25998
Draft
Copilot wants to merge 2 commits into
Draft
Migrate to ESLint 10 (flat config), @typescript-eslint v8, TypeScript 5.9, @types/node 22#25998Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
- Bump eslint ^8.57.1 → ^10.0.0
- Add @eslint/js ^10.0.0 (now a required explicit dep for flat config)
- Bump @typescript-eslint/{eslint-plugin,parser} ^6.21.0 → ^8.61.0
- Bump eslint-config-prettier ^8.3.0 → ^10.1.8
- Bump typescript ~5.2 → ~5.9
- Replace eslint-plugin-import ^2 (no ESLint 10 support) with
eslint-plugin-import-x ^4.16.2 (drop-in fork with ESLint 10 support)
eslint.config.mjs:
- Update import to use eslint-plugin-import-x
- Remove prettier from plugins (eslint-config-prettier is not a plugin)
- Remove rules deleted in @typescript-eslint v8:
ban-types, no-loss-of-precision, no-extra-parens, no-var-requires
- Rename no-empty-interface → no-empty-object-type (v8 replacement)
- Turn off new v8 recommended rules to avoid flagging pre-existing code:
no-unsafe-function-type, no-wrapper-object-types,
no-unused-expressions
- Turn off new ESLint 10 recommended rules:
no-unassigned-vars, no-useless-assignment, preserve-caught-error
Source files: remove stale eslint-disable @typescript-eslint/ban-types
comments (rule removed in v8) from 11 files across src/client and src/test
tsconfig.json, tsconfig.extension.json, pythonExtensionApi/tsconfig.json:
- Add skipLibCheck: true to resolve type conflict between
@types/eslint-scope (webpack transitive dep) and ESLint 10 bundled types
Copilot
AI
changed the title
[WIP] Migrate to ESLint 10 with flat config
Migrate to ESLint 10 (flat config), @typescript-eslint v8, TypeScript 5.9, @types/node 22
Jun 8, 2026
rzhao271
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the linting and TypeScript toolchain: ESLint 8→10,
@typescript-eslintv6→v8, TypeScript5.2→5.9, and aligns supporting packages. The repo already had a flat config (eslint.config.mjs), so no config format migration was needed.package.jsoneslint:^8.57.1→^10.0.0@eslint/js: added^10.0.0(now required as an explicit dep)@typescript-eslint/{eslint-plugin,parser}:^6.21.0→^8.61.0eslint-config-prettier:^8.3.0→^10.1.8eslint-plugin-import→ replaced witheslint-plugin-import-x^4.16.2(maintained ESLint 10-compatible fork; all rules were already'off'so this is a drop-in swap)typescript:~5.2→~5.9eslint.config.mjseslint-plugin-import-xeslint-config-prettierfromplugins(it's a config object, not an ESLint plugin)@typescript-eslintv8:ban-types,no-loss-of-precision,no-extra-parens,no-var-requiresno-empty-interface→no-empty-object-type(v8 rename);no-var-requires→no-require-imports(v8 rename)@typescript-eslintv8 recommended to avoid flagging pre-existing code:no-unsafe-function-type,no-wrapper-object-types,no-unused-expressionsjs.configs.recommended:no-unassigned-vars,no-useless-assignment,preserve-caught-errorSource files (11 files)
Removed stale
// eslint-disable @typescript-eslint/ban-typesdirectives fromsrc/client/andsrc/test/. The rule was removed in@typescript-eslintv8, causing ESLint to error on unresolvable rule references.tsconfig.json/tsconfig.extension.json/pythonExtensionApi/tsconfig.jsonAdded
"skipLibCheck": trueto resolve a type conflict between@types/eslint-scope(transitive dep via webpack) and ESLint 10's newly bundled TypeScript declarations.Original prompt
Created from VS Code.