Skip to content

Mention frozendict in object.__hash__() documentation#148867

Merged
StanFromIreland merged 3 commits into
python:mainfrom
jonathandung:patch-1
Jun 8, 2026
Merged

Mention frozendict in object.__hash__() documentation#148867
StanFromIreland merged 3 commits into
python:mainfrom
jonathandung:patch-1

Conversation

@jonathandung

@jonathandung jonathandung commented Apr 22, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

The portion of the data model page documenting object.__hash__ currently acknowledges that besides the built-in hash function, 'operations on members of hashed collections including set, frozenset and dict' would also call __hash__. That list should be expanded in light of 3.15 implementing frozendict, which also falls into this category.

📚 Documentation preview 📚: https://cpython-previews--148867.org.readthedocs.build/

@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Apr 22, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Apr 22, 2026
@jonathandung

jonathandung commented Apr 22, 2026

Copy link
Copy Markdown
Contributor Author

Please add skip issue.

johnslavik
johnslavik requested changes Apr 22, 2026
View reviewed changes
Comment thread Doc/reference/datamodel.rst Outdated
ZeroIntensity
ZeroIntensity requested changes Apr 22, 2026
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the Oxford comma change, per @johnslavik's suggestion, and then I'll happily merge this.

@bedevere-app

bedevere-app Bot commented Apr 22, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@jonathandung @johnslavik
Readd Oxford comma
6130ede 
Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
@jonathandung

jonathandung commented May 10, 2026

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

@bedevere-app

bedevere-app Bot commented May 10, 2026

Copy link
Copy Markdown

Thanks for making the requested changes!

@ZeroIntensity: please review the changes made to this pull request.

@read-the-docs-community

read-the-docs-community Bot commented May 10, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #32621874 | 📁 Comparing 982dc5d against main (09233bd)

  🔍 Preview build  

114 files changed · + 3 added · ± 111 modified

+ Added

± Modified

@StanFromIreland StanFromIreland changed the title Note that frozendict is also a hashed collection that invokes the __hash__ method of objects in data model documentation Mention frozendict in object.__hash__() documentation Jun 8, 2026
StanFromIreland
StanFromIreland approved these changes Jun 8, 2026
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StanFromIreland StanFromIreland added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 8, 2026
@StanFromIreland StanFromIreland merged commit e376211 into python:main Jun 8, 2026
36 of 38 checks passed
@miss-islington-app

miss-islington-app Bot commented Jun 8, 2026

Copy link
Copy Markdown

Thanks @jonathandung for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Jun 8, 2026
@bedevere-app

bedevere-app Bot commented Jun 8, 2026

Copy link
Copy Markdown

GH-151077 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 8, 2026
StanFromIreland pushed a commit that referenced this pull request Jun 8, 2026
@miss-islington @jonathandung
[3.15] Mention frozendict in object.__hash__() documentation (GH-…
0f964f4 
…148867) (#151077)

(cherry picked from commit e376211)

Co-authored-by: Jonathan Dung <jonathandung@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnslavik johnslavik johnslavik approved these changes

@StanFromIreland StanFromIreland StanFromIreland approved these changes

@willingc willingc Awaiting requested review from willingc willingc is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jonathandung @ZeroIntensity @johnslavik @StanFromIreland @picnixz