Improve authlib/integrations/requests_client/oauth2_session.pyi#15865
Open
noelleleigh wants to merge 6 commits into
Open
Improve authlib/integrations/requests_client/oauth2_session.pyi#15865noelleleigh wants to merge 6 commits into
authlib/integrations/requests_client/oauth2_session.pyi#15865noelleleigh wants to merge 6 commits into
Conversation
- Correct parent classes for `OAuth2Auth`, `OAuth2ClientAuth`, and `OAuth2Session`. - Remove comments that are now redundant. - Add type annotations to method arguments and return types. - Use variable annotations with `ClassVar` instead of assignments for class variables.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Oh, I guess the stubs from one library can't be used in another one? |
error: Signature of "__call__" incompatible with supertype "requests.auth.AuthBase" [override] note: Superclass: note: def __call__(self, r: PreparedRequest) -> PreparedRequest note: Subclass: note: def [_R: Request] __call__(self, req: _R) -> _R error: Signature of "__call__" incompatible with supertype "requests.auth.AuthBase" [override] note: Superclass: note: def __call__(self, r: PreparedRequest) -> PreparedRequest note: Subclass: note: def [_R: Request] __call__(self, req: _R) -> _R
The signature is different from Session.request
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OAuth2Auth,OAuth2ClientAuth, andOAuth2Session.ClassVarinstead of assignments for class variables.Update 2026-06-08
types-oauthlibandrequestsas dependencies ofAuthlibto pull in their types.OAuth2Clientto allow subclasses to override them more broadly.