[1.x] Improve PHP 8.4+ support by avoiding implicitly nullable types#224
Merged
Conversation
clue
reviewed
May 28, 2024
WyriHaximus
force-pushed
the
1.x-nullable
branch
2 times, most recently
from
4f9b975 to
89f954f
Compare
clue
reviewed
Jun 5, 2024
This changeset backports reactphp#223 from `3.x` to `1.x` to improve PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260. The same idea applies, but v1 requires manual type checks to support legacy PHP versions as the nullable type syntax requires PHP 7.1+ otherwise. Builds on top of reactphp#223, reactphp#204 and reactphp#218
clue
approved these changes
Jun 5, 2024
clue
left a comment
clue
left a comment
Member
There was a problem hiding this comment.
@WyriHaximus Thanks for the update, changes LGTM! 
SimonFrings
approved these changes
Jun 5, 2024
SimonFrings
left a comment
SimonFrings
left a comment
Member
There was a problem hiding this comment.
Nice, let's get this in 👍
This was referenced Jul 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset backports #223 from
3.xto1.xto improve PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260. The same idea applies, but v1 requires manual type checks to support legacy PHP versions as the nullable type syntax requires PHP 7.1+ otherwise.Builds on top of #223, #182, reactphp/promise#260, reactphp/async#87 and reactphp/promise-timer#70