Skip to content

Removing JsonProperty from library #3069

Description

@Luna712

Describe your suggested feature

I was just wanting opinion before doing this @fire-light42. I wanted to remove JsonProperty annotations from everything in library only for now (everything is fully migrated and seems to fully work). After which I could move remaining back compat stuff to jvmCommonMain which should fully maintain binary compatibility, and then we can fully compile the library to JS once just one or two more PRs of mine are merged. #2836 might be the only one left that would be fully required for KMP...

I would also like more opinion on what the future should be with the library and SerializationClassTester, which I was thinking of repurposing into just testing that all serializable classes work by injecting random fake data into it similar to current, but rather than comparing, just ensure that serialization works in kotlinx.serialization.

Update: Oh also #2828 is needed for KMP. Even though I rebased that immediately before making this issue I forgot about it. My bad...
Update 2: Ugh I also forgot about #2800 lol. So that is needed too, although I could actually do an expect/actual for that if necessary in the meantime. But still a couple more PRs then I thought are still needed.

Other details

I made this as a feature request even though it isn't as I can't make a normal issue here.

Acknowledgements

  • My suggestion is NOT about adding a new provider
  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions