feat(changeset): shared batch→changes resolver in core#216
Draft
behinddwalls wants to merge 1 commit into
Draft
Conversation
Add submitqueue/core/changeset, the single place the orchestrator resolves batch identity into the changes a batch contains — consolidating the batch -> requests -> changes walk that the build, merge, and score controllers each performed privately. Resolver exposes two single-batch fidelities, both keyed per batch so callers with several batches loop and keep the per-batch boundary: ChangesForBatch returns raw changes (URIs only, no change-store read) for the build and merge stages, and DetailedForBatch returns one ChangeInfo per claimed URI with provider details read from the change store, for the score stage and detail-aware analyzers. Ships with a store-backed implementation (depending only on the request and change stores), a programmable in-memory fake, a generated mock, and tests. The package is added unused; extensions adopt it in later branches. entity.BatchChanges is repurposed as DetailedForBatch's output (doc comment only). The mocks make-target gains the new package.
This was referenced Jun 8, 2026
albertywu
approved these changes
Jun 8, 2026
JamyDev
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add submitqueue/core/changeset, the single place the orchestrator resolves batch identity into the changes a batch contains — consolidating the batch -> requests -> changes walk that the build, merge, and score controllers each performed privately.
Resolver exposes two single-batch fidelities, both keyed per batch so callers with several batches loop and keep the per-batch boundary: ChangesForBatch returns raw changes (URIs only, no change-store read) for the build and merge stages, and DetailedForBatch returns one ChangeInfo per claimed URI with provider details read from the change store, for the score stage and detail-aware analyzers.
Ships with a store-backed implementation (depending only on the request and change stores), a programmable in-memory fake, a generated mock, and tests. The package is added unused; extensions adopt it in later branches. entity.BatchChanges is repurposed as DetailedForBatch's output (doc comment only). The mocks make-target gains the new package.
Test Plan
Issues
Stack