Sync v3 session encoding with wallet-contracts-v3#365
Open
ScreamingHawk wants to merge 6 commits into
Open
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca80af7e18
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 05ac5ffbcf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Member
|
LGTM just that small comment |
The explicit-session and implicit-attestation encodings had drifted from the deployed v3 contracts, so any config image hash / session signature go-sequence produced was rejected on-chain. Re-sync three changes the contracts made (and mirror the sequence.js primitives JSON): - SessionPermissions: add chainId (32 bytes, after signer) and encode deadline as uint64 (8 bytes) instead of 32. Matches SessionSig recoverConfiguration and permission.ts. - Attestation authData: append issuedAt (uint64, 8 bytes) so the attestation hash matches LibAttestation.toHash. Serialize issuedAt as a decimal string in JSON to match attestation.ts. - Wire issuedAt through the cmd/sequence CLI input. Add regression tests with byte vectors verified against the contracts via forge (recoverConfiguration / LibAttestation.toHash). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
HashCallWithReplayProtection hashed the payload's parentWallets verbatim. The session-holding wallet is the last parent wallet in the signing context, but on chain it is the verifying contract (msg.sender), not a parent entry, so it must be dropped before hashing to match SessionSig.hashPayloadCallIdx. Wallet-bound digest comes from the partial payload replay audit fix (wallet-contracts-v3 9c19609, Code4rena S-93/S-169, #89). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
EncodeSessionPermissions encodes deadline into an 8-byte buffer via big.Int.FillBytes, which panics on a negative value or one that does not fit in uint64 (e.g. a max-value "no expiry" deadline). Validate the range and return an error instead of crashing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
AttestationFromJson accepted a JSON-number issuedAt via an unchecked uint64 cast, so a negative, fractional or out-of-range value was silently coerced (e.g. -1 -> MaxUint64) and the library would hash/sign a different attestation than the JSON represented. Reject negatives, fractions and values outside uint64, matching the string path. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ScreamingHawk
force-pushed
the
fix/v3-session-encoding-sync
branch
from
July 13, 2026 19:08
3d5e23e to
920ba26
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 920ba266ff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
#362 was merged with the digest function renamed to HashPayloadCallIdx; update the parent-wallets test to the new name so the package builds. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Numeric JSON attributes were decoded and encoded unsafely: an unquoted number above 2^53 was silently rounded by encoding/json before use, and a negative or over-wide chainId/valueLimit was encoded as its absolute value or spilled past the fixed 32-byte field. Add bigIntFromJSON, a single decoder shared by chainId, valueLimit, deadline and attestation issuedAt: it parses strings and json.Number exactly and rejects float64 that is non-integer or at/above 2^53. EncodeSessionPermissions now rejects chainId and valueLimit that are negative or wider than uint256. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
|
LGTM |
Agusx1211
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-sequence's session encoding was ported before several contract changes and never caught up, so any explicit-session config, attestation, or session-call digest it produced was rejected on-chain. This re-syncs it (cross-checked against the sequence.js primitives):
chainId(32 bytes aftersigner) and encodedeadlineasuint64(8 bytes, was 32) — wallet-contracts-v3cc6890eand8a376ad. MatchesSessionSig.recoverConfiguration/permission.ts.issuedAt(uint64, 8 bytes) toauthDataso the attestation hash matchesLibAttestation.toHash—12b8c27. Serialized as a decimal string in JSON to matchattestation.ts.msg.sender(the verifying contract), not a parent entry, so the signing context's trailing parent must be removed — the wallet-bound digest comes from the partial-payload-replay audit fix (9c19609, Code4rena S-93/S-169, wallet-contracts-v3#89, the same fix Implement session call digest for v3 sessions #362 implements).issuedAtthrough thecmd/sequenceCLI input.Encoding vectors in the added tests are verified against the contracts via forge (
recoverConfiguration,LibAttestation.toHash,hashPayloadCallIdx). Only the current (Rc4+) session manager is targeted; the deprecated Dev1/Dev2/Rc3 digest schemes are intentionally not supported.🤖 Generated with Claude Code