fix: allow contract view calls without execute#6
Open
Urazanev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
view/purecontract calls through the read path even when--executeis not provided--executeagw-clicommand nameWhy
The upvoting skill documents read-only contract calls such as
voteCost(),currentEpoch(), anduserVotesRemaining(address)usingcontract write --dry-run. Before this change those calls returned only a preview envelope, so the user could not get the actual return value needed before voting. Sinceview/purecalls cannot mutate state, they can safely be executed viareadContractwithout requiring explicit execute intent.Test plan
corepack pnpm jest test/agw-runtime.test.ts --runInBandcorepack pnpm jest --runInBandcorepack pnpm lint./node_modules/.bin/tsc -p tsconfig.json --noEmitcorepack pnpm --dir packages/agw-core check-typescorepack pnpm --dir packages/agw-cli check-typescorepack pnpm --dir app check-types