Skip to content

[PWGUD] DPL Analysis: use API instead of direct construction #16790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolavick merged 1 commit into from
Jun 24, 2026
+10 −10
Merged

[PWGUD] DPL Analysis: use API instead of direct construction #16790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions PWGUD/Core/UDHelpers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
#include <Framework/Logger.h>
#include <Framework/SliceCache.h>

#include <TLorentzVector.h>

Check failure on line 31 in PWGUD/Core/UDHelpers.h

View workflow job for this annotation

GitHub Actions / O2 linter

[root/lorentz-vector] 

Do not use the TLorentzVector legacy class. Use std::array with RecoDecay methods or the ROOT::Math::LorentzVector template instead.

#include <Rtypes.h>

Expand Down Expand Up @@ -130,7 +130,7 @@
// check [min,max]BC to overlap with [bcs.iteratorAt([0,bcs.size() - 1])
if (maxBC < bcs.iteratorAt(0).globalBC() || minBC > bcs.iteratorAt(bcs.size() - 1).globalBC()) {
LOGF(debug, "<compatibleBCs> No overlap of [%d, %d] and [%d, %d]", minBC, maxBC, bcs.iteratorAt(0).globalBC(), bcs.iteratorAt(bcs.size() - 1).globalBC());
return T{{bcs.asArrowTable()->Slice(0, 0)}, static_cast<uint64_t>(0)};
return bcs.emptySlice();
}

// find slice of BCs table with BC in [minBC, maxBC]
Expand Down Expand Up @@ -164,7 +164,7 @@
}

// create bc slice
T bcslice{{bcs.asArrowTable()->Slice(minBCId, maxBCId - minBCId + 1)}, static_cast<uint64_t>(minBCId)};
auto bcslice = bcs.rawSlice(minBCId, maxBCId - minBCId + 1);
bcs.copyIndexBindings(bcslice);
LOGF(debug, " size of slice %d", bcslice.size());
return bcslice;
Expand All @@ -179,7 +179,7 @@

// return if collisions has no associated BC
if (!collision.has_foundBC() || ndt < 0) {
return T{{bcs.asArrowTable()->Slice(0, 0)}, static_cast<uint64_t>(0)};
return bcs.emptySlice();
}

// get associated BC
Expand Down Expand Up @@ -220,7 +220,7 @@
// return if collisions has no associated BC
if (!collision.has_foundBC()) {
LOGF(debug, "Collision %i - no BC found!", collision.globalIndex());
return T{{bcs.asArrowTable()->Slice(0, 0)}, static_cast<uint64_t>(0)};
return bcs.emptySlice();
}

// get associated BC
Expand Down Expand Up @@ -924,7 +924,7 @@
bool isPythiaCDE(T MCparts)
{
for (const auto& mcpart : MCparts) {
if (mcpart.pdgCode() == 9900110) {

Check failure on line 927 in PWGUD/Core/UDHelpers.h

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
return true;
}
}
Expand All @@ -940,9 +940,9 @@
if (MCparts.size() < 3) {
return false;
} else {
if (MCparts.iteratorAt(0).pdgCode() != 443013)

Check failure on line 943 in PWGUD/Core/UDHelpers.h

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
return false;
if (std::abs(MCparts.iteratorAt(1).pdgCode()) != 13)

Check failure on line 945 in PWGUD/Core/UDHelpers.h

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
return false;
if (MCparts.iteratorAt(2).pdgCode() != -MCparts.iteratorAt(1).pdgCode())
return false;
Expand Down Expand Up @@ -984,11 +984,11 @@
if (MCparts.size() < 6) {
return false;
} else {
if (MCparts.iteratorAt(0).pdgCode() != 2212)

Check failure on line 987 in PWGUD/Core/UDHelpers.h

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
return false;
if (MCparts.iteratorAt(1).pdgCode() != 2212)

Check failure on line 989 in PWGUD/Core/UDHelpers.h

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
return false;
if (MCparts.iteratorAt(2).pdgCode() != 2212)

Check failure on line 991 in PWGUD/Core/UDHelpers.h

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
return false;
if (MCparts.iteratorAt(3).pdgCode() != 2212)
return false;
Expand Down Expand Up @@ -1029,13 +1029,13 @@
// -----------------------------------------------------------------------------
// Invariant mass of GRANIITTI generated event
template <typename T>
TLorentzVector ivmGraniittiCDE(T MCparts)

Check failure on line 1032 in PWGUD/Core/UDHelpers.h

View workflow job for this annotation

GitHub Actions / O2 linter

[root/lorentz-vector] 

Do not use the TLorentzVector legacy class. Use std::array with RecoDecay methods or the ROOT::Math::LorentzVector template instead.
{
TLorentzVector ivm = TLorentzVector(0., 0., 0., 0.);

Check failure on line 1034 in PWGUD/Core/UDHelpers.h

View workflow job for this annotation

GitHub Actions / O2 linter

[root/lorentz-vector] 

Do not use the TLorentzVector legacy class. Use std::array with RecoDecay methods or the ROOT::Math::LorentzVector template instead.

// is this a GRANIITTI generated event?
if (isGraniittiCDE(MCparts)) {
TLorentzVector lvtmp;

Check failure on line 1038 in PWGUD/Core/UDHelpers.h

View workflow job for this annotation

GitHub Actions / O2 linter

[root/lorentz-vector] 

Do not use the TLorentzVector legacy class. Use std::array with RecoDecay methods or the ROOT::Math::LorentzVector template instead.

for (int ii = 7; ii < MCparts.size(); ii++) {
auto mcPart = MCparts.iteratorAt(ii);
Expand Down
12 changes: 6 additions & 6 deletions PWGUD/TableProducer/DGBCCandProducer.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,11 +468,11 @@ struct DGBCCandProducer {
auto fwdTracksArray = ftibcSlice.begin().fwdtrack_as<FTCs>();
isDG = dgSelector.IsSelected(diffCuts, bcRange, tracksArray, fwdTracksArray);
} else {
auto fwdTracksArray = FTCs{{fwdtracks.asArrowTable()->Slice(0, 0)}, (uint64_t)0};
auto fwdTracksArray = fwdtracks.emptySlice();
isDG = dgSelector.IsSelected(diffCuts, bcRange, tracksArray, fwdTracksArray);
}
} else {
auto fwdTracksArray = FTCs{{fwdtracks.asArrowTable()->Slice(0, 0)}, (uint64_t)0};
auto fwdTracksArray = fwdtracks.emptySlice();
isDG = dgSelector.IsSelected(diffCuts, bcRange, tracksArray, fwdTracksArray);
}

Expand Down Expand Up @@ -514,11 +514,11 @@ struct DGBCCandProducer {
auto fwdTracksArray = ftibcPart.begin().fwdtrack_as<FTCs>();
isDG = dgSelector.IsSelected(diffCuts, bcRange, tracksArray, fwdTracksArray);
} else {
auto fwdTracksArray = FTCs{{fwdtracks.asArrowTable()->Slice(0, 0)}, (uint64_t)0};
auto fwdTracksArray = fwdtracks.emptySlice();
isDG = dgSelector.IsSelected(diffCuts, bcRange, tracksArray, fwdTracksArray);
}
} else {
auto fwdTracksArray = FTCs{{fwdtracks.asArrowTable()->Slice(0, 0)}, (uint64_t)0};
auto fwdTracksArray = fwdtracks.emptySlice();
isDG = dgSelector.IsSelected(diffCuts, bcRange, tracksArray, fwdTracksArray);
}

Expand Down Expand Up @@ -683,11 +683,11 @@ struct DGBCCandProducer {
auto fwdTracksArray = ftibc.fwdtrack_as<FTCs>();
isDG2 = dgSelector.IsSelected(diffCuts, bcRange, tracksArray, fwdTracksArray);
} else {
auto fwdTracksArray = FTCs{{fwdtracks.asArrowTable()->Slice(0, 0)}, (uint64_t)0};
auto fwdTracksArray = fwdtracks.emptySlice();
isDG2 = dgSelector.IsSelected(diffCuts, bcRange, tracksArray, fwdTracksArray);
}
} else {
auto fwdTracksArray = FTCs{{fwdtracks.asArrowTable()->Slice(0, 0)}, (uint64_t)0};
auto fwdTracksArray = fwdtracks.emptySlice();
isDG2 = dgSelector.IsSelected(diffCuts, bcRange, tracksArray, fwdTracksArray);
}

Expand Down
Loading