Normalize integration card categories to match routes#1088
Closed
jottakka wants to merge 5 commits into
Closed
Conversation
Extract a client-safe toolkit-category helper so integration index links and catalog enrichment use the same category allow-list as static routes, instead of raw catalog categories that can miss pages or 404. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Keep catalog enrichment aligned with route generation: toolkit JSON wins for docsLink, and category values are normalized before cards/filters use them. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Independent follow-up to #1065: share a client-safe |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Author
Treat explicit empty-string category/docsLink as present (matching ??), and widen ToolkitWithDocsLink so normalized "others" typechecks through the build. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Superseded by #1065 (category normalize + client-safe helper were folded in there). |
Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 99ec991. Configure here.
others redirects to the index and has no [toolkitId] route, so keep it as a normalize fallback only and exclude it from valid/clickable card links. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toolkit-categoryhelper (INTEGRATION_CATEGORIES+normalizeCategory) so browser cards never import server-only route codetoIntegrationLink, sidebar sync, and keep route generation on the same allow-listcategoryfrom toolkit JSON (same source of truth as routes), not onlydocsLinkIndependent of #1065: closes the remaining card/route category contract gap Bugbot found there.
Test plan
pnpm exec vitest --run --exclude '.worktrees/**' tests/integration-index-links.test.ts toolkit-docs-generator/tests/app-lib/toolkit-category.test.ts toolkit-docs-generator/tests/app-lib/toolkit-static-params.test.ts toolkit-docs-generator/tests/scripts/sync-toolkit-sidebar.test.ts/others/...and matcheslistValidIntegrationLinkswhen a page exists thereMade with Cursor