Match HTTP/2 content-encoding with AsciiString constants instead of toLowerCase#2207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The HTTP/2 content decompressor matched the content-encoding header by calling toString().toLowerCase(Locale.ROOT) on every response, allocating a String per response just to test for gzip/deflate.
Modification:
Match case-insensitively in place with AsciiString.containsIgnoreCase against the HttpHeaderValues.GZIP/DEFLATE constants, and use the HttpHeaderNames constants for the header get/remove. AsciiString case-folding is ASCII-only, so it also removes the Turkish-locale concern the Locale.ROOT call guarded against.
Result:
No per-response String allocation when checking content-encoding; the gzip/deflate activation set is unchanged (br/zstd still pass through), with new tests covering the case-insensitive and substring matches.