{Profile} Test GH team being codeowner#33665
Closed
isra-fel wants to merge 1 commit into
Closed
Conversation
|
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
|
Hi @isra-fel, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Member
Author
|
Identity squad added as reviewer immediately - 
|
Member
Author
|
Green after 1 approval 
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes Azure CLI’s profile command module logic for resolving the resource endpoint in get_access_token, but the current edit introduces invalid Python syntax that will break module import/runtime execution.
Changes:
- Modified the
get_access_tokencode path that derivesresourcefromcmd.cli_ctx.cloud.endpointswhenresource_typeis provided.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if resource is None and resource_type: | ||
| endpoints_attr_name = cloud_resource_type_mappings[resource_type] | ||
| resource = getattr(cmd.cli_ctx.cloud.endpoints, endpoints_attr_name) | ||
| resource = getattr(cmd.cli_ctx.cloud.endpoints, endpoints_attr_name)xyz |
isra-fel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expectation:
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.