fix(agents): update container deploy schema to use protocol_versions and container_configuration

[v1212]

Summary

Migrate container deploy API schema to match the latest service-side TypeSpec definition:

• container_protocol_versions → protocol_versions (unified with code deploy)
• top-level image → container_configuration.image

Reference

Schema change is documented in the official REST API reference:
https://learn.microsoft.com/en-us/azure/foundry/agents/how-to/deploy-hosted-agent?pivots=rest#create-an-agent

The documented create-agent payload uses:
json { "definition": { "kind": "hosted", "container_configuration": { "image": "myacr.azurecr.io/my-agent:v1" }, "protocol_versions": [ {"protocol": "responses", "version": "1.0.0"} ], "cpu": "1", "memory": "2Gi" } }

Changes

• models.go: Added ContainerConfigurationAPI struct, updated HostedAgentDefinition to use protocol_versions (via struct tag) and container_configuration for container image. Removed custom MarshalJSON. Updated UnmarshalJSON for backward compat with legacy fields.
• map.go: Container deploy path now populates ContainerConfiguration instead of bare Image.
• optimize_deploy.go: normalizeProtocolVersions handles both new and legacy field names. Added normalizeContainerImage to migrate legacy top-level image on raw maps (service responses bypass UnmarshalJSON).
• service_target_agent.go: Display code reads from ContainerConfiguration.Image with empty-string guard.
• Tests: All updated and passing, including legacy unmarshal backward compat test.

Backward Compatibility

UnmarshalJSON still reads legacy API responses that use container_protocol_versions and top-level image, migrating them to the new schema in memory. The optimize-deploy path also normalizes raw definition maps via normalizeContainerImage and normalizeProtocolVersions.

Fixes #8828

[github-actions]

📋 Prioritization Note

Thanks for the contribution! The linked issue isn't in the current milestone yet.
Thank you for logging this issue; our team is reviewing it. If you need urgent prioritization, tag @RickWinter and @kristenwomack to let us know.

[Copilot]

Pull request overview

Updates the azure.ai.agents extension’s hosted/container agent wire schema to match the latest service TypeSpec by unifying protocol versions under protocol_versions and moving the container image under container_configuration.image, while keeping backward-compatible deserialization for legacy responses.

Changes:

• Introduces ContainerConfigurationAPI and updates HostedAgentDefinition JSON serialization/deserialization to use protocol_versions + container_configuration (with legacy-field migration on unmarshal).
• Updates container deploy request construction and display logic to read/write ContainerConfiguration.Image.
• Updates unit tests to validate the new schema and legacy unmarshal behavior.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
cli/azd/extensions/azure.ai.agents/internal/project/service_target_agent.go	Displays hosted agent image from ContainerConfiguration.Image.
cli/azd/extensions/azure.ai.agents/internal/pkg/agents/agent_yaml/map.go	Builds container deploy requests using container_configuration.image.
cli/azd/extensions/azure.ai.agents/internal/pkg/agents/agent_yaml/map_test.go	Updates assertions to validate container image is set via ContainerConfiguration.
cli/azd/extensions/azure.ai.agents/internal/pkg/agents/agent_api/models.go	Adds ContainerConfigurationAPI, switches to protocol_versions, and migrates legacy fields on unmarshal.
cli/azd/extensions/azure.ai.agents/internal/pkg/agents/agent_api/models_test.go	Updates schema expectations and adds a legacy-unmarshal test.
cli/azd/extensions/azure.ai.agents/internal/cmd/optimize_deploy.go	Normalizes/migrates protocol versions to protocol_versions when cloning definitions.
cli/azd/extensions/azure.ai.agents/internal/cmd/optimize_deploy_test.go	Updates optimize deploy definition tests for the new schema/migration behavior.

[jongio]

CI is failing: golangci-lint reports a gofmt error in optimize_deploy_test.go:124. The map literal in TestBuildDeployDefinition_NormalizesProtocolVersion mixes alignment styles (some keys padded, some not). Running gofmt -s -w . should fix it.

Beyond the formatting issue, one functional gap: normalizeProtocolVersions now migrates the legacy container_protocol_versions field to protocol_versions on raw maps, but there is no equivalent migration for the legacy top-level image field to container_configuration.image. Since AgentVersionObject.Definition is typed as any (line 299 of models.go), the service response is stored as a raw map[string]any that never passes through HostedAgentDefinition.UnmarshalJSON. If the service still returns the legacy schema, the optimize-deploy path will forward image unchanged in new version requests.

The overall approach (unifying to protocol_versions, removing custom MarshalJSON, adding backward-compat UnmarshalJSON) is solid and well-tested.

[jongio]

My earlier inline concern about the optimize-deploy raw map path still applies: normalizeProtocolVersions migrates legacy container_protocol_versions to protocol_versions in buildDeployDefinition, but there is no equivalent for the legacy top-level image field to container_configuration.image. Since extractLatestDefinition produces a map[string]any (bypassing HostedAgentDefinition.UnmarshalJSON), any legacy image from the service response would pass through unchanged in new version requests.

If the service can still return old-schema responses for existing agent versions, consider adding a normalizeContainerConfiguration function alongside normalizeProtocolVersions. If the service has fully migrated all responses to the new schema, this can be safely ignored.

[trangevi]

Comment isn't blocking, but something to consider in addition to Jon's comments