[Storage] [STG 104] NFS List V2 Files and Directories#47643
Open
weirongw23-msft wants to merge 7 commits into
Open
[Storage] [STG 104] NFS List V2 Files and Directories#47643weirongw23-msft wants to merge 7 commits into
weirongw23-msft wants to merge 7 commits into
Conversation
weirongw23-msft
commented
Jun 24, 2026
| self.file_mode = kwargs.get("x-ms-mode") | ||
| self.link_count = kwargs.get("x-ms-link-count") | ||
| self.nfs_file_type = kwargs.get("x-ms-file-file-type") | ||
| self.link_text = None |
Member
Author
There was a problem hiding this comment.
Get File Properties REST API does not return x-ms-link-text, x-ms-device-major, x-ms-device-minor, etc. These fields are only available from listing XML, which is populated in _from_generated.
weirongw23-msft
requested review from
jalauzon-msft and
vincenttran-msft
as code owners
|
|
||
| # A canned "List Files and Directories" response containing every NFS item type. It is not possible to | ||
| # create block devices, character devices, FIFOs, or sockets through the REST interface, so a mocked | ||
| # response is used to verify that the SDK can parse all of them. |
Member
There was a problem hiding this comment.
Are there any NFS specific fields we could verify? If so, we should probably have a real test that only verifies the things we know we have along with this mock test to verify everything.
| Possible str values are "timestamps", "Etag", "Attributes", "PermissionKey", | ||
| "Permissions", "LinkCount", "NfsAttributes", and "All". | ||
| The values "Permissions", "LinkCount", "NfsAttributes", and "All" apply to NFS shares, | ||
| with the exception of "All" which can also be used on SMB shares. |
Member
There was a problem hiding this comment.
nit: This doc reads a bit weird. Maybe just mention "Permissions", "LinkCount", "NfsAttributes" only apply to NFS shares.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.