Fix remove duplicated vars in xml parsing#1154
Open
doguto wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In src/xml_parsing.cpp, XMLParser::PImpl::createNodeFromXML(), port_name and port_value were declared at the outer scope of the attribute-iteration loop, then immediately re-declared with identical values inside the if(IsAllowedPortName(...)) block, shadowing the outer variables.
The inner declarations (lines 809–810) are dead code and have been removed. Behavior is unchanged.
Resolve #1153
Checklist
• No API / ABI / behavioral changes introduced
• No new unit test needed (the change is a pure dead-code removal with no behavioral effect)
• pre-commit applied
• ./run_clang_tidy.sh executed and clean