New Explore cmd + maintainence#88
Conversation
…anch name, and git hash
Not sure how this was even made.
Now we have reproducible build's again. Dependencies were also updated + reordered. Via https://github.com/littlerobots/version-catalog-update-plugin.
- Create CitySelectorMenu for selecting cities within states - Refactor StateSelectorMenu to dynamically detect states and sub-cities - Update CountrySelectorMenu to open state selector for USA - Use Hardcoded Logic for NYC City This enables navigation flow: USA → States → Cities (e.g., NY → NYC) & USA -> States -> New Jersey.
Make warp creation, editing, and deletion instantly responsive by: - Updating local state immediately before API calls - Sending success messages without waiting for network - Processing API calls and cache updates asynchronously - Rolling back local changes if API calls fail This eliminates the multi-second delay users experienced when creating or editing warps, as operations no longer block on: 1. Network API request completion 2. Full cache refresh from API 3. BlueMap marker updates Closes #89.
Qodana for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Fix NoSuchElementException when creating warps at coordinates with no location data (ocean/unmapped areas). Menu now reopens after errors so players can retry from a different location. Fixes #58.
- Add @nonnull annotations to method parameters overriding @NotNull - Add null checks and Objects.requireNonNull() for potentially null returns - Replace printStackTrace() with proper ComponentLogger.error() calls - Remove unused imports across multiple files - Convert field constants to local variables where appropriate - Add @SuppressWarnings for unavoidable unchecked warnings - Fix stream API calls (collect(toList()) → toList()) - Replace size comparisons with isEmpty() - Fix non-regex replaceAll() to use replace() - Use parameterized logging to avoid string concatenation Fixes 125+ code quality issues identified in Qodana report while maintaining all functionality. The main remaining issues are Message / Component related which will be fixed once we add translation. Hopefully very soon. Now we don't set a baseline anymore for better reporting.
Implements #42. At least the light version of it.
This fixes parsing of other coordinate format's like the Simplex (BTE Israel) format.
| ChatHelper.sendSuccessfulMessage(creator, "Successfully created the warp group %s!", warpGroup.getName()); | ||
| // Refresh BlueMap markers | ||
| refreshBluemapMarkers(); | ||
| NetworkModule.getInstance().updateCache().thenRun(() -> refreshBluemapMarkers()).exceptionally(e -> { |
There was a problem hiding this comment.
It's better to use formatting like
NetworkModule.getInstance().updateCache()
.thenRun(() -> refreshBluemapMarkers())
.exceptionally(e ->
in these long chains of conditionals to have better readability.
There was a problem hiding this comment.
Can you look up what intellij setting that is?
- Now it repair's the isconnected state for the Build team is running on - when it's not connected to a proxy it's always false. - Network API priotize the same ip as main, if it doesn't find it returns the same entry. - Network switch possiblility is only choosen if the running team is also connected to the server
Jasupa
left a comment
There was a problem hiding this comment.
Please go through all files and use chained method calls where possible, plus change long else/elseif/if/for chains in all files where possible, because now you only did it for some.
| protected ItemStack getStreetLampItem(String id){ | ||
| return Item.create(XMaterial.SEA_LANTERN.parseMaterial(), "§eStreet Lamp #" + id, ListUtil.createList("§7Click to select this street lamp type.")); | ||
| protected ItemStack getStreetLampItem(String id) { | ||
| return Item.create(Objects.requireNonNull(XMaterial.SEA_LANTERN.get()), "§eStreet Lamp #" + id, ListUtil.createList("§7Click to select this street lamp type.")); |
There was a problem hiding this comment.
You are still using the old colour coding system here. Please go through all files to see where you can still change them.
| ChatHelper.sendSuccessfulMessage(creator, "Successfully created the warp group %s!", warpGroup.getName()); | ||
| // Refresh BlueMap markers | ||
| refreshBluemapMarkers(); | ||
| NetworkModule.getInstance().updateCache().thenRun(() -> refreshBluemapMarkers()).exceptionally(e -> { |
Regions are now also use the continent from the region itself and not from the build team, now most are in the correct part in the menu. Now the Listeners for the navigator item are only registered if it's enabled in the config, so it will not clash with other plugins + saves resources.
This includes also important dependency Updates: