[FIX]: point Artifact_names to (with migrations) builds to restore CEA-708 output#1122
Open
x15sr71 wants to merge 3 commits into
Open
[FIX]: point Artifact_names to (with migrations) builds to restore CEA-708 output#1122x15sr71 wants to merge 3 commits into
x15sr71 wants to merge 3 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Problem
CEA-708 regression tests have shown "No output generated but there should be" since March 17. Root cause: the artifact names this platform downloads no longer point to the full-Rust builds.
On March 17, two CCExtractor CI commits restructured the build artifacts into a dual min-Rust / full-Rust setup:
After these commits, the artifact names
Artifact_namesmatches against —"CCExtractor Linux build"and"CCExtractor Windows x64 Release build"— resolve to the-DDISABLE_RUST(min-Rust) builds.DISABLE_RUSTcompiles out the Rust DTVCC decoder (src/lib_ccx/ccx_dtvcc.h), which handles all CEA-708--serviceoutput. The platform has been downloading and testing the wrong binary on both platforms ever since.The Linux commit (3d0ce97) explicitly noted that this platform's
Artifact_nameswould need updating:Evidence
--svc 1 --out=srt; the full-Rust ("with migrations") build writesout.p1.svc01.srt— exactly the path the platform expects.Fix
Point both artifact names to the
(with migrations)(full-Rust) builds, which is the build the platform is intended to test.