test: add Pest v1 security test infrastructure#214
Merged
TheWitness merged 2 commits intoJul 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds initial security-oriented test scaffolding under tests/ intended to prevent unsafe reuse of raw request values in HTML output within the monitor plugin.
Changes:
- Adds a “unit” PHP script that validates expected HTML escaping behavior for a sample payload.
- Adds an “integration” PHP script that scans
monitor_controller.php/monitor_render.phpfor specific hardening call patterns. - Adds an “e2e” PHP script that scans for specific raw
get_request_var(...)reuse string patterns.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| tests/unit/test_request_output_escaping.php | Adds a basic escaping check for a sample payload. |
| tests/Integration/test_monitor_request_output_wiring.php | Adds a static source scan asserting expected escaping/encoding call sites exist. |
| tests/e2e/test_monitor_no_raw_request_reuse.php | Adds a static source scan asserting specific raw-request string patterns are absent. |
xmacan
approved these changes
Jul 9, 2026
browniebraun
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separates the Pest security test infrastructure into its own PR as requested.