Summarizer: reject view-class summaries on payable methods#53
Draft
shellygr wants to merge 1 commit into
Draft
Conversation
…rizer A NONDET/CONSTANT/ALWAYS summary erases a payable callee's ETH effects; a caller that accounts for the transferred value then reverts on every path and its rules pass vacuously. The summarizer's put tool now audits the typed CVL AST against the build's method inventory and rejects such summaries; the prompt states the rule. Raw/edit escape hatches are removed from this flow so every write is auditable. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interface summarizer's LLM freely wrote
=> NONDETfor payable methods. That erases the callee's ETH effects; a caller that accounts for the transferred value (e.g. a post-call balance check) then reverts on every path, and its rules pass vacuously.composer/cvl/summary_audit.py: walks the typed CVL AST (no text matching), flags NONDET/CONSTANT/PER_CALLEE_CONSTANT/ALWAYS on payable methods, incl. wildcard and catch-all entries. Payability comes from the build'sall_methods.json; missing inventory degrades to no-op.Tests: 11 new; full suite 114 passed; pyright clean.
🤖 Generated with Claude Code