Skip to content

fix: emit perf maps when not parsing the full inlining logs from V8 #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GuillaumeLagrange merged 1 commit into from
Jun 24, 2026
+4 −2
Merged

fix: emit perf maps when not parsing the full inlining logs from V8 #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/codspeed.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,6 @@ jobs:
CODSPEED_WALLTIME_PROFILER: samply
with:
mode: walltime
# TODO: Remove this once runner is released
runner-version: v4.17.7-alpha.2
run: |
pnpm turbo run bench --filter=@codspeed/tinybench-plugin
pnpm turbo run bench --filter=@codspeed/vitest-plugin
Expand Down
4 changes: 4 additions & 0 deletions packages/core/src/introspection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export const getV8Flags = () => {
case "walltime": {
// Emit the V8 jitdump
flags.push("--perf-prof");

const v8LogDir = process.env.CODSPEED_V8_LOG;
if (v8LogDir) {
flags.push(
Expand All @@ -50,6 +51,9 @@ export const getV8Flags = () => {
`--logfile=${path.join(v8LogDir, V8_LOG_FILENAME_PATTERN)}`,
],
);
} else {
// Just output the perf.map
flags.push("--perf-basic-prof");
}
}
}
Expand Down
Loading