Skip to content

Glasgow | 25-ITP-May | Arthur Chan | Sprint 3 | implement-and-rewrite-tests#1407

Open
Motorcycle-lab wants to merge 6 commits into
CodeYourFuture:mainfrom
Motorcycle-lab:implement-and-rewrite-tests
Open

Glasgow | 25-ITP-May | Arthur Chan | Sprint 3 | implement-and-rewrite-tests#1407
Motorcycle-lab wants to merge 6 commits into
CodeYourFuture:mainfrom
Motorcycle-lab:implement-and-rewrite-tests

Conversation

@Motorcycle-lab

@Motorcycle-lab Motorcycle-lab commented Jun 26, 2026

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

my exercises in implement-and-rewrite tests

Questions

What websites or apps do you recommend me build to learn the foundation of Javascript ?

@Motorcycle-lab Motorcycle-lab added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 🏕 Priority Mandatory This work is expected labels Jun 26, 2026
LonMcGregor
LonMcGregor reviewed Jul 1, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you make a commit with simply a comment of "for committing". Do you know what you need to do in this task?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 1, 2026
@Motorcycle-lab Motorcycle-lab added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 2, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 2, 2026
@github-actions

This comment has been minimized.

Sign in to view
@Motorcycle-lab Motorcycle-lab force-pushed the implement-and-rewrite-tests branch from 90451be to 212966d Compare July 2, 2026 15:58
@Motorcycle-lab Motorcycle-lab added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 2, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 2, 2026
@Motorcycle-lab Motorcycle-lab added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 3, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 3, 2026
@Motorcycle-lab

Motorcycle-lab commented Jul 3, 2026

Copy link
Copy Markdown
Author

Why did you make a commit with simply a comment of . Do you know what you need to do in this task?
I have accidentally saved all the sprint 3 files into a branch, so I created a new branch and transfer the sprint 3 implement-and-rewrite-tests only. There are some problems during transferring. All my exercises are lost. I have re-uploaded all the commit now, but I could not pass the test.

@Motorcycle-lab Motorcycle-lab added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 🏕 Priority Mandatory This work is expected 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Motorcycle-lab @LonMcGregor