-
-
Notifications
You must be signed in to change notification settings - Fork 390
London | 26-May-ITP | Yonatan Teklemariam | Sprint 3 | Practice-tdd #1414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Yonatanteklemariam
wants to merge
8
commits into
CodeYourFuture:main
Choose a base branch
from
Yonatanteklemariam:coursework/sprint-3-practice-tdd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2d01d60
written jest tests for all the three functions and output tests as ex…
Yonatanteklemariam 091f62b
Fix function name from repeatedStr to repeatStr
Yonatanteklemariam 49f7123
Update test to repeat string three times
Yonatanteklemariam 16e1c56
fixed the tdd tests
Yonatanteklemariam debcf2a
Merge branch 'coursework/sprint-3-practice-tdd' of https://github.com…
Yonatanteklemariam 9b54862
fixed typo in get-ordinal-number file
Yonatanteklemariam ce61555
corrected errors in tests and commited the changes
Yonatanteklemariam 2002729
added more tests for repeat-str-tests
Yonatanteklemariam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,21 @@ | ||
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| if ( | ||
| typeof stringOfCharacters !== "string" || | ||
| typeof findCharacter !== "string" | ||
| ) { | ||
| return 0; | ||
| } | ||
| let count = 0; | ||
| for (let i = 0; i < stringOfCharacters.length; i++) { | ||
| if (stringOfCharacters[i] === findCharacter) { | ||
| count++; | ||
| } | ||
| } | ||
| return count; | ||
| } | ||
|
|
||
| console.log(countChar("aaaaa", "a")); // should return 5 | ||
| console.log(countChar("bravo", "u")); // should return 0 | ||
| console.log(countChar("", "a")); // should return 0 | ||
| console.log(countChar("1-2-3-4-5-", "-")); // should return 5 | ||
| console.log(countChar("AaAa", "A")); // should return 2 | ||
| module.exports = countChar; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,22 @@ | ||
| function getOrdinalNumber(num) { | ||
| return "1st"; | ||
| if (typeof num !== "number" || !Number.isInteger(num) || num < 0) { | ||
| throw new Error("Input must be a non-negative integer"); | ||
| } | ||
|
|
||
| const lastTwo = num % 100; | ||
| const lastDigit = num % 10; | ||
|
|
||
| // Special cases: 11th, 12th, 13th | ||
| if (lastTwo === 11 || lastTwo === 12 || lastTwo === 13) { | ||
| return `${num}th`; | ||
| } | ||
|
|
||
| // Normal cases | ||
| if (lastDigit === 1) return `${num}st`; | ||
| if (lastDigit === 2) return `${num}nd`; | ||
| if (lastDigit === 3) return `${num}rd`; | ||
|
|
||
| return `${num}th`; | ||
| } | ||
|
|
||
| module.exports = getOrdinalNumber; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,28 @@ | ||
| function repeatStr() { | ||
| // Your implementation of this function must *not* call String.prototype.repeat (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/repeat). | ||
| // The goal is to re-implement that function, not to use it. | ||
| return "hellohellohello"; | ||
| // Your implementation of this function must *not* call String.prototype.repeat (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/repeat). | ||
| // The goal is to re-implement that function, not to use it. | ||
| function repeatStr(str, count) { | ||
| if (typeof str !== "string") { | ||
| return ""; | ||
| } | ||
| if (count < 0) { | ||
| throw new Error("Invalid input: count must be a non-negative integer"); | ||
| } | ||
|
|
||
| let result = ""; | ||
|
|
||
| for (let i = 0; i < count; i++) { | ||
| result += str; | ||
| } | ||
|
|
||
| return result; | ||
| } | ||
| console.log(repeatStr("hello", 3)); // Output: "hellohellohello" | ||
| console.log(repeatStr("fella", 1)); // Output: "fella" | ||
| console.log(repeatStr("fella", 0)); // Output: "" | ||
| console.log(repeatStr("ab", 3)); // Output: "ababab" | ||
| console.log(repeatStr("a", 1000).length); // Output: 1000 | ||
| console.log(repeatStr("", 5)); // Output: "" | ||
| console.log(repeatStr([], 3)); // Output: "" | ||
| console.log(repeatStr(null, 3)); // Output: "" | ||
|
|
||
| module.exports = repeatStr; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have correctly tested the edge cases here (1, 0, error). Can you think of any other test cases that would make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I've now added tests for null, "", non-string inputs and large repeat counts. Could you please now review it? Thanks for your patience