Skip to content

London | 26-ITP-May | Dipa Sarker | Sprint 2 | Coursework#1421

Open
Dipa-Sarker wants to merge 5 commits into
CodeYourFuture:mainfrom
Dipa-Sarker:Coursework/sprint-2
Open

London | 26-ITP-May | Dipa Sarker | Sprint 2 | Coursework#1421
Dipa-Sarker wants to merge 5 commits into
CodeYourFuture:mainfrom
Dipa-Sarker:Coursework/sprint-2

Conversation

@Dipa-Sarker

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  1. Errors
  • Predicted errors in each file in the errors section
  • Ran each file using Node.js
  • Explained why each error occurs
  1. Debug
  • Predicted why each program was not working
  • Ran files with Node.js to confirm issues
  • Fixed bugs in the code
  1. Implement
  • Implemented required functions:
    • BMI calculator
    • Case conversion function
    • Pounds conversion function
  • Tested each function with multiple inputs
  1. Interpret
  • Analyzed the given program
  • Used documentation to understand unfamiliar syntax
  • Used console.log to verify variable values
  1. Extend
  • Wrote additional tests for edge cases
  • Fixed bugs found during testing of 24-hour to 12-hour conversion

@Dipa-Sarker Dipa-Sarker added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 28, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, there is just one question I have about brackets - you can see my comment in one place where you use brackets that are maybe not needed. See if you can spot the other locations throughout your code.

// The correct code:

function multiply(a, b) {
return(a * b);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to use brackets here?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants