Manchester | 26-ITP-May| John Robinson | Sprint 1 | Coursework#1426

Open

JohnRob-jnr wants to merge 11 commits into

CodeYourFuture:mainfrom

JohnRob-jnr:Sprint-1

JohnRob-jnr commented Jun 29, 2026 •

edited

Loading

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have made alterations & replied to the questions / comments by reviewer

JohnRob-jnr added 7 commits

June 22, 2026 22:23


          Refactor count.js to clarify variable update and implement initials e…

c97a1ab

…xtraction in initials.js


          Update initials.js to comment out console.log, implement dir and ext …

bd03363

…variables in paths.js, enhance random.js with detailed explanation, and fix variable declaration issues in mandatory-errors files.


          Fix typo in replaceAll function call and update comments for clarity …

…in percentage-change.js


          Enhance comments in 2-time-format.js for clarity and detail

daaaec9


          Enhance comments in 3-to-pounds.js for detailed step-by-step explanation

2721e61


          Update 12HourClockTime format to include AM/PM designation

ccdaaa7


          Fix variable naming for consistency in 4.js

JohnRob-jnr added 📅 Sprint 1 Needs Review Module-Structuring-And-Testing-Data labels

JohnRob-jnr added 3 commits

June 30, 2026 00:21


          Fix variable redeclaration issues and enhance error prediction commen…

04cdbd3

…ts in key error examples


          Enhance comments for clarity and consistency across key error examples

7b05d22


          Fix getLastDigit function to accept parameter and implement BMI calcu…

2c6fe69

…lation

cjyuan reviewed

View reviewed changes

Sprint-1/1-key-exercises/1-count.js Outdated

Comment on lines +8 to +11

+              // Answer: Line 3 is updating the value of the variable 'count' by adding 1 to its current value.
+              // The = operator is used to update / assign a new value to the variable 'count'.
+              // It takes the current value of 'count', adds 1 to it, and then assigns that new value back to 'count'.
+              //

cjyuan Jul 3, 2026

Contributor

Operation like count = count + 1 is very common in programming, and there is a programming term describing such operation.

Could you find out what one-word programming term describes the operation on line 3?

JohnRob-jnr Jul 3, 2026

Author

Would it be "reassigning"? using the assignment operator

Sprint-1/2-mandatory-errors/4.js Outdated

Sprint-1/3-mandatory-interpret/1-percentage-change.js

    
              // A) 5 in total - lines 4, 5, 10

              // b) Run the code and identify the line where the error is coming from - why is this error occurring? How can you fix this problem?

              // A) Missing comma in line 5 in function .replaceAll which is causing the error.

cjyuan Jul 3, 2026

Contributor

We could more precisely describe "A comma is missing between "," and "" in the function call" as:
A comma is missing between the ___________s.

What is this programming term that refers to the values passed to a function? It begins with an 'a'.

JohnRob-jnr Jul 3, 2026

Author

This would be Argument?

cjyuan added Reviewed and removed Needs Review labels

JohnRob-jnr commented Jul 3, 2026

Author

Hey @cjyuan I have made changes where required & replied in comments. Thanks for reviewing this

JohnRob-jnr added Needs Review and removed Reviewed labels

github-actions Bot commented Jul 3, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-1/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions Bot removed the Needs Review label

github-actions Bot commented Jul 3, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-1/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

1 similar comment

github-actions Bot commented Jul 3, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-1/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

JohnRob-jnr added Needs Review Complete labels

github-actions Bot commented Jul 3, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-1/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

1 similar comment

github-actions Bot commented Jul 3, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-1/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions Bot removed Needs Review labels

JohnRob-jnr removed the Complete label

JohnRob-jnr added the Needs Review label

github-actions Bot commented Jul 3, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-1/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions Bot removed the Needs Review label

github-actions Bot commented Jul 3, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-1/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

JohnRob-jnr force-pushed the Sprint-1 branch from 18cde05 to 2c6fe69 Compare

July 3, 2026 16:17


          Fix variable naming for consistency in count.js and 4.js

92af3ef

JohnRob-jnr added the Needs Review label

github-actions Bot commented Jul 3, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-1/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions Bot removed the Needs Review label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Structuring-And-Testing-Data 📅 Sprint 1