London | 26-May-ITP | Yonatan Teklemariam | Sprint 3 | implement and rewrite tests#1452
Open
Yonatanteklemariam wants to merge 16 commits into
Conversation
Remove check for zero numerator in isProperFraction function.
Added checks for finite and integer values of numerator and denominator.
Refactor isProperFraction to validate integers instead of finite numbers.
Fix syntax error in isProperFraction function.
…ps://github.com/Yonatanteklemariam/Module-Structuring-and-Testing-Data into coursework/sprint-3-implement-and-rewrite-tests
Yonatanteklemariam
added
the
Needs Review
cjyuan
reviewed
Jul 4, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Could you look up
When one must close a reviewed PR and then reopen a new PR from the same codebase, what should they include in the new PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
removed the redundant checks based on mathematical reference and corrected the syntax errors in the commented out code snippet.
Supersedes and replaced the old PR: #1381
Renamed the branch to better align with PR formatting rules
The code remains exactly the same as the previous PR; only the branch name was updated and some comments added
###Carrying over from #1381. @cjyuan had already reviewed, and advised on removal of redundant checks which is now fixed. Plus he advised me to align to the PR format which is also resolved.