fix: repoint notice-dismiss callback to Notification::dismiss (regular_dismiss does not exist)

[ineagu]

Problem

Promotions::load() registers the notice-dismiss AJAX handler against a method that does not exist:

// src/Modules/Promotions.php
if ( get_option( $this->option_neve, false ) !== true ) {
    add_action( 'wp_ajax_themeisle_sdk_dismiss_notice', 'ThemeisleSDK\Modules\Notification::regular_dismiss' );
}

Notification::regular_dismiss is defined nowhere in the SDK (git log -S "function regular_dismiss" is empty across history). The real handler is Notification::dismiss, which the SDK already references for this exact action (e.g. the remove_action( …, [ 'ThemeisleSDK\Modules\Notification', 'dismiss' ] ) in the neve-themes-popular branch).

When the broken callback is reached — a user dismissing a review notice (<product_key>_review_flag) or a promo notice on a non-Neve site — WordPress invokes it through WP_Hook and PHP fatals:

Uncaught TypeError: call_user_func_array(): Argument #1 ($callback) must be a valid callback,
class ThemeisleSDK\Modules\Notification does not have a method "regular_dismiss"
in wp-includes/class-wp-hook.php:341

→ HTTP 500 / blank admin page on dismiss.

Why it's intermittent (and portfolio-wide)

• The callback is registered by the Promotions module for any product bundling the SDK — not plugin-specific. Reproduced identically with Otter (otter_review_flag) and FreshRank (freshrank_ai_review_flag).
• Present in every 3.3.x release checked; introduced long ago and never had a matching method definition.
• Neve sites are immune — the themeisle_sdk_promotions_neve_installed !== true gate closes, so the bad callback is never registered.
• On non-Neve sites it's latent until the broken callback is actually reached (i.e. Notification::dismiss doesn't wp_die() first), which is why many sites never hit it.

Fix

One line: point the callback at the existing Notification::dismiss. It's idempotent with the registration already done in Notification::load() (identical static callback + priority de-duplicates in WP_Hook), so sites that were never hitting the bug see no behavioural change; sites that were fataling now dismiss cleanly.

Verified locally against the real Notification class by dispatching the hook exactly as class-wp-hook.php:341 does: with the fix the dismiss succeeds; before it, the verbatim production TypeError is raised.

🤖 Generated with Claude Code

[ineagu]

@HardeepAsrani I got this by change on my ionutn site from freshrank and I know we sometimes get 1 star reviews from users and I was trying to find a root cause, I replicated & tested the fix, not sure if I am missing anything

[Copilot]

Pull request overview

This PR fixes a fatal error in the Promotions module by repointing the wp_ajax_themeisle_sdk_dismiss_notice AJAX handler from a non-existent ThemeisleSDK\Modules\Notification::regular_dismiss method to the existing ThemeisleSDK\Modules\Notification::dismiss method, preventing invalid-callback crashes when dismissing SDK notices.

Changes:

• Update the Promotions module’s notice-dismiss AJAX callback to ThemeisleSDK\Modules\Notification::dismiss.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[ineagu]

Closing — opened against the wrong repo. Moved to the canonical repo: Codeinwp/themeisle-sdk-main.