Add safe snprintf rule#275
Open
lucic71 wants to merge 7 commits into
Open
Conversation
lucic71
marked this pull request as draft
July 20, 2026 13:19
lucic71
marked this pull request as ready for review
July 20, 2026 14:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The snprintf safe rule uses the new
libcc2rs::format_cfunction. The rule is:Initially, I planned to use
format!instead oflibcc2rs::format_cat line 1 because that's definitely more idiomatic. However we need to support runtime format strings, for example:The
format!macro in rust does not support runtime format strings. It only works with compile time format strings. For this reason I createdlibcc2rs::format_cwhich internally uses the sprintf crate. The role offormat_cis to validate the format string, convert eachlibcc2rs::VaArgtosprintf::Printfthen do the actual formatting.