Add safe translation for open/read/write/close#277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the building blocks of safe file descriptor IO translation. In Rust, C file descriptors (int), are usually translated as OwnedFd/BorroweFd. nix also uses OwnedFd/BorrowedFd inside the IO APIs, for example open is defined as:
pub fn open<P: ?Sized + NixPath>(path: &P, oflag: OFlag, mode: Mode, ) -> Result<OwnedFd>However, we cannot directly translate integers to OwnedFd/BorrowedFd. An integer can be used as both integer and OwnedFd at the same time, which Rust does not allow. For example:
To overcome this limitation, allow integers to be translated as i32, and keep a global FdRegistry which contains mappings of type
i32 -> OwnedFd:This way, integer operations on file descriptors continue to work, for example
int fd = -1orif (fd > 0)and functions that use file descriptor access the OwnedFd/BorrowedFd through the FdRegistry, for example:In the following PRs I will add the remaining safe IO rules.