Fix sdist to include the C submodule and build files#53
Merged
Conversation
`python setup.py sdist` (and thus the published PyPI sdist) is unbuildable: it
ships only setup.py + metadata, with none of the nlopt C sources, extensions.py,
or the top-level CMakeLists.txt. `pip install <sdist>` then fails at:
CMake Error: The source directory "..." does not appear to contain
CMakeLists.txt
Root cause is MANIFEST.in:
- `recursive-include extern/nlopt` has no file pattern, so setuptools silently
includes none of the extern/nlopt submodule.
- extensions.py (imported by setup.py) and the root CMakeLists.txt (passed to
CMake by extensions.py) are not listed, so they are excluded as well.
Add the missing `*` pattern and explicitly include extensions.py, CMakeLists.txt,
and setup.cfg. The resulting sdist (~2 MB) builds from source with SWIG + NumPy.
charleysaintNV
force-pushed
the
fix-sdist-manifest
branch
from
July 8, 2026 18:30
ef0c323 to
c0888a7
Compare
Contributor
Author
|
@DanielBok Please review |
DanielBok
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python setup.py sdist(and thus the published PyPI sdist) is unbuildable: it ships only setup.py + metadata, with none of the nlopt C sources, extensions.py, or the top-level CMakeLists.txt.pip install <sdist>then fails at:Root cause is MANIFEST.in:
recursive-include extern/nlopthas no file pattern, so setuptools silently includes none of the extern/nlopt submodule.Add the missing
*pattern and explicitly include extensions.py, CMakeLists.txt, and setup.cfg. The resulting sdist (~2 MB) builds from source with SWIG + NumPy.