Cleanup UM sample#366
Conversation
…icense header to Aspire app. Added a the UserManagementSample.GettingStarted csproj to sln file. Code was there and being used in Aspire, but project wasn't added to sln.
…lient can reach it
maartenba
left a comment
maartenba
left a comment
There was a problem hiding this comment.
One small comment, and...
Can you keep/bring back UserManagementSample.GettingStarted? It is the project we use in the docs getting started tutorial and I'd like to keep it so we can test the docs changes more easily (and one day, reference the code from this sample).
No problem. Do you mind if I put that code somewhere else? I don't think it needed to be in that location. What about in the /Quickstarts folder? |
|
Quickstarts is all of the IS quickstarts. Can be the original location, or a directory next to the other UM samples (no strong opinion), only need to make sure the links to this sample in docs are updated. |
|
I just didn't think we should have 2 samples the same directory. It would be confusing to users. I'll keep a single /UserManagement directory for all UM samples, and add sub folders for the two samples we have. Will move the password registration on in there later on once we can merge it in. |
…heir own folder. Now there's a /FullSample and /GettingStarted directories
maartenba
left a comment
maartenba
left a comment
There was a problem hiding this comment.
Approved, in case you want to merge at any point
…ityserver.dev.localhost TLD because it was a little confusing in the spots that needed it to be localhost:5001, but more importantly so the Google External Auth would work.
Thanks. Will merge once the docs PR is approved so the links aren't messed up too long. DuendeSoftware/docs.duendesoftware.com#1140 |
2 participants
UserManagementSample.GettingStartedproject/code. It wasn't being used for anything.