fix(cli): make required_version advisory, warn on eval failure instead of prompting/exiting#1396
Draft
christso wants to merge 1 commit into
Draft
fix(cli): make required_version advisory, warn on eval failure instead of prompting/exiting#1396christso wants to merge 1 commit into
christso wants to merge 1 commit into
Conversation
…d of prompting/exiting
Deploying agentv with
|
| Latest commit: |
dd86f45
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://64f7e17d.agentv.pages.dev |
| Branch Preview URL: | https://fix-1395-required-version-ad.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
required_versionmismatches advisory by default: warn once, never prompt, self-update, or exit unless--strictis explicitly used.required_version.Verification
bun run verifyManual UAT
Temp project used
.agentv/config.yamlwithrequired_version: ">=999.0.0", a mock target, and deterministiccontainsassertions.Red (
origin/main):1from threshold failure and printedRESULT: FAIL, but no summary note about the version mismatch.0; mismatch warning was stderr-only.Green (this branch):
1from threshold failure and printed the version mismatch note in the summary.0with no summary note, only one low-noise stderr warning.Failure-time note observed:
Closes #1395