Fix constructor input decoding to preserve full ABI payload by Copilot · Pull Request #954 · FISCO-BCOS/java-sdk

Copilot · 2026-06-16T02:52:07Z

ContractCodec.decodeConstructorInput(abi, bin, input) was decoding constructor args through the method-input path, which incorrectly drops the first 4 bytes as if a function selector were present. Constructor calldata has no selector after the bytecode, so the first parameter was truncated and decoded incorrectly.

Constructor decode path
- Route decodeConstructorInput(...) through direct ABI payload decoding instead of decodeMethodAndGetInputObject(...).
- This aligns the object-returning path with decodeConstructorInputToString(...), which already decodes the full constructor parameter bytes.
Regression coverage
- Add a focused constructor round-trip test with actual parameters (uint256, string).
- Verify decodeConstructorInput(...) now returns the same values represented by the already-correct string decode path.
Behavioral impact
- Method input decoding remains unchanged.
- Constructor decoding now preserves the full encoded parameter payload instead of stripping a non-existent selector.

public List<Object> decodeConstructorInput(String abi, String bin, String input)
        throws ContractCodecException {
    String paramsInput = StringUtils.substringAfter(input, bin);
    if (paramsInput.isEmpty()) {
        return new ArrayList<>();
    }

    ContractABIDefinition contractABIDefinition = this.abiDefinitionFactory.loadABI(abi);
    ABIDefinition abiDefinition = contractABIDefinition.getConstructor();
    ABIObject inputObject = ABIObjectFactory.createInputObject(abiDefinition);
    return ContractCodecTools.decodeJavaObject(inputObject, paramsInput, isWasm);
}

* Initial plan * Remove fisco-bcos.org URL, replace with GitHub repo URL in build.gradle Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com>

Copilot

Pull request overview

Fixes ContractCodec.decodeConstructorInput(...) to decode constructor calldata correctly by decoding the full ABI-encoded parameter payload (constructor input has no 4-byte selector to strip), aligning behavior with decodeConstructorInputToString(...).

Changes:

Route decodeConstructorInput(...) through direct ABI payload decoding (instead of method-input decoding that strips 4 bytes).
Add a regression test that round-trips constructor params (uint256, string) and asserts object/string decode consistency.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/main/java/org/fisco/bcos/sdk/v3/codec/ContractCodec.java	Updates constructor input decoding to avoid dropping the first 4 bytes and decode full parameter payload.
src/test/java/org/fisco/bcos/sdk/v3/test/codec/ABICodecTest.java	Adds a focused constructor decode test with parameters to prevent regressions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+        try {
+            return ContractCodecTools.decodeJavaObject(inputObject, paramsInput, isWasm);
+        } catch (Exception e) {
+            logger.error(" exception in decodeConstructorInput : {}", e.getMessage());
+        }
+        String errorMsg = " cannot decode in decodeConstructorInput with appropriate interface ABI";
+        logger.error(errorMsg);
+        throw new ContractCodecException(errorMsg);


…arams

sonarqubecloud · 2026-06-22T09:29:06Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

…arams

codecov · 2026-07-16T08:43:52Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.06%. Comparing base (ab0390c) to head (f871b45).

Additional details and impacted files

@@               Coverage Diff                @@
##             release-3.9.0     #954   +/-   ##
================================================
  Coverage            64.05%   64.06%           
+ Complexity            4567     4566    -1     
================================================
  Files                  430      430           
  Lines                17628    17634    +6     
  Branches              1969     1969           
================================================
+ Hits                 11292    11297    +5     
  Misses                5576     5576           
- Partials               760      761    +1

Flag	Coverage Δ
unittest	`64.06% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

kyonRay · 2026-07-16T09:01:36Z

Codecov Report

❌ Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review. ✅ Project coverage is 64.04%. Comparing base (ab0390c) to head (30a2891).

Files with missing lines Patch % Lines
...ava/org/fisco/bcos/sdk/v3/codec/ContractCodec.java 28.57% 5 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##             release-3.9.0     #954      +/-   ##
===================================================
- Coverage            64.05%   64.04%   -0.02%     
  Complexity            4567     4567              
===================================================
  Files                  430      430              
  Lines                17628    17634       +6     
  Branches              1969     1969              
===================================================
+ Hits                 11292    11293       +1     
- Misses                5576     5581       +5     
  Partials               760      760              
Flag Coverage Δ
unittest 64.04% <28.57%> (-0.02%) ⬇️
Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness. 📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

@copilot fix coverage

Copilot · 2026-07-16T09:05:15Z

[Codecov](https://app.codecov.io/gh/FISCO-BCOS/java-sdk/pull/954?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FISCO-B...

Added focused coverage for the constructor decode paths in commit f871b45.

Added testDecodeConstructorInputWithoutParams to cover the empty-params return path.
Added testDecodeConstructorInputWithInvalidPayload to cover the failure/exception path.

Also re-ran ABICodecTest and verifyGoogleJavaFormat successfully.

Copilot AI and others added 2 commits March 4, 2026 13:34

Initial plan

b8872e4

Copilot AI assigned Copilot and kyonRay Jun 16, 2026

Copilot started work on behalf of kyonRay June 16, 2026 03:31 View session

fix: decode constructor params without stripping selector

5d03848

Copilot AI changed the title ~~[WIP] Fix ContractCodec.decodeConstructorInput to avoid stripping bytes~~ Fix constructor input decoding to preserve full ABI payload Jun 16, 2026

Copilot finished work on behalf of kyonRay June 16, 2026 03:37

Copilot AI requested a review from kyonRay June 16, 2026 03:37

kyonRay approved these changes Jun 17, 2026

View reviewed changes

kyonRay marked this pull request as ready for review June 17, 2026 04:02

Copilot AI review requested due to automatic review settings June 17, 2026 04:02

kyonRay approved these changes Jun 17, 2026

View reviewed changes

Copilot started reviewing on behalf of kyonRay June 17, 2026 04:02 View session

Copilot AI reviewed Jun 17, 2026

View reviewed changes

kyonRay changed the base branch from master to release-3.9.0 June 22, 2026 09:28

Merge branch 'release-3.9.0' into copilot/fix-corrupted-constructor-p…

84461cb

…arams

Merge branch 'release-3.9.0' into copilot/fix-corrupted-constructor-p…

30a2891

…arams

Copilot started work on behalf of kyonRay July 16, 2026 09:01 View session

<test>(codec): add constructor decode edge-case coverage

f871b45

Copilot finished work on behalf of kyonRay July 16, 2026 09:06

Copilot AI requested a review from kyonRay July 16, 2026 09:06

kyonRay approved these changes Jul 16, 2026

View reviewed changes

kyonRay merged commit 84ea6f8 into release-3.9.0 Jul 16, 2026
5 of 6 checks passed

kyonRay deleted the copilot/fix-corrupted-constructor-params branch July 16, 2026 09:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix constructor input decoding to preserve full ABI payload#954

Fix constructor input decoding to preserve full ABI payload#954
kyonRay merged 6 commits into
release-3.9.0from
copilot/fix-corrupted-constructor-params

Copilot AI commented Jun 16, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

sonarqubecloud Bot commented Jun 22, 2026

Uh oh!

codecov Bot commented Jul 16, 2026 •

edited

Loading

Uh oh!

kyonRay commented Jul 16, 2026

Codecov Report

Uh oh!

Copilot AI commented Jul 16, 2026

[Codecov](https://app.codecov.io/gh/FISCO-BCOS/java-sdk/pull/954?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FISCO-B...

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Copilot AI commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

sonarqubecloud Bot commented Jun 22, 2026

Quality Gate passed

Uh oh!

codecov Bot commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kyonRay commented Jul 16, 2026

Codecov Report

Uh oh!

Copilot AI commented Jul 16, 2026

[Codecov](https://app.codecov.io/gh/FISCO-BCOS/java-sdk/pull/954?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FISCO-B...

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Jun 16, 2026 •

edited

Loading

codecov Bot commented Jul 16, 2026 •

edited

Loading