feat: surface the selected variant on flags#221
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for variant keys in multivariate feature options. It updates the MultivariateFeatureOptionModel type definition, maps the variant key in flagsmith/mappers.py when present, and adds a variant field to the Flag model, populated from evaluation results and API flags. Additionally, the flagsmith-flag-engine dependency is updated to 10.2.0, and corresponding unit tests are introduced. The feedback suggests adding a unit test to explicitly verify that null variant keys are correctly dropped to prevent future regressions.
In local evaluation, expose which multivariate variant an identity was bucketed into via a new `Flag.variant`: - the variant's key when a named variant is selected, - "control" when the identity falls in the control bucket, - None otherwise (standard feature, unkeyed variant, or no identity). Threads the variant key from the environment document through the evaluation context so the engine can return it, and surfaces the engine's `variant` on the Flag. Requires flag-engine >=10.2.0. `Flag.from_api_flag` reads `variant` too, so remote evaluation will populate it once the API returns it.
gagantrivedi
force-pushed
the
feat/multivariate-variant
branch
from
e50ada6 to
f15af26
Compare
Zaimwa9
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Flag.variant— which multivariate variant an identity was bucketed into:"control"for the control bucket,Noneotherwise (standard feature, unkeyed variant, or no identity).Threads the variant key from the environment document through the evaluation context so the engine returns it.
Flag.from_api_flagreads it too, so remote evaluation populates it once the API returns it. Bumpsflagsmith-flag-engineto^10.2.0.