feat(input): ⌘F opens the host's find bar (onFind callback)#20
Merged
Conversation
The find-in-page backend already exists end-to-end (CefWebController.find/stopFind + onFindResult down to native CefFindHandler); the only gap was ⌘F, which the focused view consumed. Add an optional onFind VoidCallback to CefWebView: ⌘F invokes it (the host opens its own find bar, which drives the existing find API) and consumes the key; when null, ⌘F falls through to the page as before. Dart-only — no native/protocol change, so no host republish. Tests: ⌘F→onFind (consumed) and ⌘F-without-onFind (falls through to the page); suite 143 green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The find-in-page backend already exists end-to-end (
CefWebController.find/stopFind+onFindResult, down to nativeCefFindHandler::OnFindResult). The only gap: ⌘F was consumed by the focused view.Adds an optional
onFindcallback toCefWebView— ⌘F invokes it (the host opens its own find bar, which drives the existing find API) and consumes the key; when null, ⌘F falls through to the page (a page can implement its own find). Dart-only — no native/protocol change, so the same host applies (no republish).Tests: ⌘F→onFind (consumed) + ⌘F-without-onFind (falls through). Suite 143 green.
🤖 Generated with Claude Code