Fix <delete> desync: mods can only delete one type per spec section#165
Open
KevinGriffin-new wants to merge 1 commit into
Open
Fix <delete> desync: mods can only delete one type per spec section#165KevinGriffin-new wants to merge 1 commit into
KevinGriffin-new wants to merge 1 commit into
Conversation
The DELETE_TAG branch never called xr.closeTag, desyncing the reader so that every element after the first <delete> in a mod specification section was silently dropped (surfacing only as top-level 'No reader found for:' warnings). Mods deleting multiple types now work. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeReader's DELETE_TAG branch doesn't consume the end tag, so the reader desyncs after the first and everything after it in that section is dropped. You only find out via "No reader found for:" warnings in the log, if you look. Added the missing closeTag call.