fix: HTML-encode single quote character (issue #546)#618
Merged
Conversation
Switch the default TextEncoder from HtmlEncoderLegacy to HtmlEncoder so
that single quotes ('), backticks (`), and equals signs (=) are HTML-encoded
as ', `, and = respectively — matching handlebars.js behavior.
Users who require the old unescaped behavior can opt in explicitly via
HandlebarsConfiguration.TextEncoder = new HtmlEncoderLegacy().
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #546
TextEncoderinHandlebarsConfigurationwasHtmlEncoderLegacy, which deliberately omitted encoding of',`, and=.HtmlEncoder, which encodes all 7 characters (&,<,>,",',`,=) matching handlebars.js behavior.HtmlEncoderLegacyremains available for users who need the old behavior — setHandlebarsConfiguration.TextEncoder = new HtmlEncoderLegacy()to opt in.Changes
source/Handlebars/Configuration/HandlebarsConfiguration.cs: Change defaultTextEncoderfromHtmlEncoderLegacytoHtmlEncodersource/Handlebars.Test/IssueTests.cs: AddIssue546_SingleQuoteIsHtmlEncodedandIssue546_HtmlSpecialCharsAreEncodedtestssource/Handlebars.Test/HandlebarsSpecCoverageTests.cs: Update spec-gap tests to reflect the now-closed gap; add legacy-encoder variant testsTest plan
Issue546_SingleQuoteIsHtmlEncodedtest confirms single quotes are encoded as'Issue546_HtmlSpecialCharsAreEncodedtheory covers all 7 special charactersHtmlEncoderTestsandHtmlEncoderLegacyTestsunchanged and still passing🤖 Generated with Claude Code