fix: parent context traversal inside custom block helpers in each (issue #539)#619
Merged
Conversation
…sue #539) When options.Template/Inverse was called with a Context struct argument, it unwrapped context.Value and created a new child frame, adding an extra level to the parent chain. This caused ../ inside the block helper's template to resolve to the current iteration item rather than its parent. Fix: pass Frame directly when Template/Inverse receives a Context struct, since Frame already represents the correct current binding context. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #539
../path traversal now correctly resolves to the parent of#eachwhen used inside a custom block helper's template body.BlockHelperOptions.Template(EncodedTextWriter, Context)andBlockHelperOptions.Inverse(EncodedTextWriter, Context): when called with aContextstruct, they unwrappedcontext.Valueand created a new child frame viaFrame.CreateFrame(context.Value), introducing an extra level in the parent chain.Framedirectly to the original template/inverse delegate, sinceFrameis already the correct current binding context (theContextstruct was always created fromFrame).Root cause
In
BlockHelperFunctionBinder, theBlockHelperOptionsis constructed withFrame = bindingContext(the#eachiteration context). TheContextstruct passed to the helper isnew Context(bindingContext, bindingContext.Value). When the user callsoptions.Template(writer, context)(passing that sameContextback), the old code didFrame.CreateFrame(context.Value), which created a new child withFrameas its parent — so../inside the template resolved toFrame.Value(the loop element) instead ofFrame.ParentContext.Value(the root data object).Test plan
Issue539_ParentContextInsideCustomBlockHelperInEachtoIssueTests.cs— confirmed it fails before the fix and passes after.🤖 Generated with Claude Code