fix: clearer error when partial registered on wrong Handlebars instance (issue #545)#622
Merged
Merged
Conversation
…ce (issue #545) Improved the HandlebarsRuntimeException message thrown when a partial cannot be resolved to include a diagnostic hint about the common pitfall of registering a partial on the static Handlebars class but compiling/rendering on a separate IHandlebars instance. Also added quotes around the partial name for readability. Added two regression tests for issue #545 covering both the correct same-instance pattern and the helpful error when mixing static and instance APIs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #545
Summary
HandlebarsRuntimeExceptionmessage thrown when a partial cannot be resolved. The new message now includes a diagnostic hint pointing to the common pitfall of registering a partial on the staticHandlebarsclass but compiling/rendering on a separateIHandlebarsinstance.PartialTests.csthat asserted the exact old message format (changed toAssert.StartsWithto be forward-compatible).IssueTests.csfor issue Unable to render Partial HandelBarReuntimeException #545.Before:
After:
Test plan
Issue545_PartialRegisteredOnInstanceIsFoundDuringRender— verifies the correct same-instance usage worksIssue545_MixingStaticAndInstanceGivesHelpfulError— verifies the improved error message is shown when mixing static and instance APIs🤖 Generated with Claude Code