fix: remove byref delegate parameters incompatible with Mono/Xamarin (issue #458)#632
Merged
Conversation
…(issue #458) TemplateDelegate and DecoratorDelegate previously used `in EncodedTextWriter` (ref readonly) parameters, which caused System.NotImplementedException on Xamarin.iOS and other Mono-based runtimes when compiled via expression trees. Remove the `in` modifier to pass EncodedTextWriter by value; also remove MakeByRefType() in CompilationContext so expression lambdas use plain parameters. Adds regression tests in Issue458Tests.cs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #458
Summary
TemplateDelegateandDecoratorDelegateusedin EncodedTextWriterparameters, which at the IL level areref readonly(byref) typesExpression.Lambdacompilation of delegates with byref parameters throwsSystem.NotImplementedException: byref delegateinfrom both delegate declarations so the parameter is passed by valueMakeByRefType()fromCompilationContextso expression tree parameters match the updated delegate signaturesDecoratorTests.cs,ClosureBuilderTests.cs) to match the new signaturesEncodedTextWriteris a smallreadonly struct(a few reference fields), so passing by value is functionally equivalent and has negligible performance impact.Test plan
source/Handlebars.Test/Issues/Issue458Tests.cs🤖 Generated with Claude Code