Support for separate Linux ARM architectures#1355
Open
MRK2009 wants to merge 1 commit into
Open
Conversation
48bc6f9 to
dd5fba5
Compare
Author
|
I think it's necessary enough to be merged. 🤔 |
0c8453c to
237e7f7
Compare
Author
|
Sorry for committing too much, I was trying to think of an alternative way to make it work. |
tobil4sk
reviewed
Jul 15, 2026
| | *HXCPP_ARMV7* | Compile arm-based devices for armv7 | | ||
| | *HXCPP_ARMV7S* | Compile arm-based devices for armv7s | | ||
| | *HXCPP_LINUX_ARMV7* | Run on a linux ARMv7 device | | ||
| | *HXCPP_LINUX_ARM64* | Run on a linux ARM64 device | |
Member
There was a problem hiding this comment.
Maybe we should instead put these in a new deprecated/removed define section, people might be using this flag and it would be confusing if they search it up in the documentation and there is no trace of it.
| defines.set("toolchain","linux"); | ||
| defines.set("linux","linux"); | ||
|
|
||
| if (defines.exists("HXCPP_LINUX_ARMV7")) |
Member
There was a problem hiding this comment.
It would be ok to remove this for hxcpp 5, but until then it would be best to avoid the breaking change and to continue to respect this define.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redo of Lily's pr #1159
You can finally use the arm architecture flags to able to compile on linux arm instead of only running it on different architectures to able to compile.
It seems lime has some armv7 linux support, but not that much because it's still supports arm64.