feat(flashing-view): add standalone flashing view#517
Conversation
…g to support two backends.
…epo, fixed .gitignores
These folders are already listed in .gitignore but were previously committed. Remove them from the git index while preserving local copies so they are no longer pushed to GitHub.
The flash station has been moved to its own standalone flashing-view app. This removes the /flashing route and its feature module from the testing-view. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Removes bundled Python integration, BLCU IPC proxy handlers, and the setup-python script that were added ad-hoc during flashing-view integration. The BLCU IPC layer will be added back properly in the flashing-view PR. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Relocates the flashing-view from the project root into frontend/flashing-view to match the layout of testing-view and competition-view. Updates the pnpm workspace to reference the new path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
l-castel
changed the title
|
You're missing package-lock.json in the flashing-view directory, which causes frontend tests to fail and also pnpm-lock.yaml is out of date P.S. Oh I'm sorry, actually you don't need package-lock.json there, I misread the CI/CD error. You only need to resolve the issue with the pnpm-lock.yaml |
|
Have you considered making this a proper window rather than just a page in the two views? (That's actually what I originally called a "view") This approach could also help avoid dependencies between the old control-station and the new parts of the code. P.S. i can see now that you had it made this way at the beginning but later integrated it into views, but i'm still not sure if we should do it this way |
|
Also, the original idea was that each folder in frontend folder represents a separate window, so we should decide if we keep it as a page and move flash-station functionality into frontend-kit or do we make it a proper view? |
…view imports Workspace kit: - Add shadcn Table component (Table, TableHeader, TableBody, TableFooter, TableRow, TableHead, TableCell, TableCaption) to @workspace/ui/components - Add XCircle to icons/notifications.ts - Add Circle to icons/shapes.ts - Add FileCode2 and Upload to icons/files.ts Flashing-view: - Replace local table.tsx with @workspace/ui/components Table - Switch all lucide-react icon imports to @workspace/ui/icons - Switch all deep shadcn path imports to @workspace/ui/components - Replace LoaderCircle with Loader2 (already in kit) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3 participants
No description provided.