fix: never send empty tag names from --tags#84
Conversation
--tags "" sent [""] to the API, creating a tag with an empty title (Hypersequent/tms-issues#2668). Tag names are now trimmed and empty entries dropped, so --tags "" sends an empty array — a no-op on create, and clears all tags on update. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Claude finished @ramilamparo's task in 2m 50s —— View job Code Review: fix: never send empty tag names from --tags
Result: Approved. The fix is clean and well-scoped — trim + filter in |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Clean, well-scoped fix. The trim + filter approach in transformTCaseFields correctly handles all edge cases (empty string, whitespace-only tags, consecutive commas, trailing commas). Tests cover both create and update paths with empty and messy input. No issues found across code quality, security, performance, or test coverage.
|
Claude finished @ramilamparo's task in 1m 13s —— View job Code Review: fix: never send empty tag names from --tags
|
|
@ramilamparo Update minor package version |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Code Review: fix: never send empty tag names from --tags
|
|
Claude finished @ramilamparo's task in 1m 8s —— View job Code Review: fix: never send empty tag names from --tags
|
3 participants
Issue:
--tags ""ontest-cases updatesent[""]to the API, which created a tag with an empty title instead of clearing the case's tags.transformTCaseFieldsnow trims tag names and drops empty entries, so--tags ""(and stray commas like--tags "a,,b") never produce empty tag names.--tags ""sends an emptytagsarray on both create and update: a no-op on create, and clears all tags on update (the backend treats a non-nil empty array as "clear").--tagshelp text.