feat(auth): add new IAM profile selector to VPC Instance Auth#250
Merged
Conversation
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
pyrooka
requested changes
Jul 15, 2026
pyrooka
left a comment
pyrooka
left a comment
Member
There was a problem hiding this comment.
The PR looks good, but we should address the two minor issues from my review before merging.
| if (StringUtils.isNotEmpty(getIamProfileId())) { | ||
| counter++; | ||
| } | ||
| if (StringUtils.isNoneEmpty(getIamProfileName())) { |
Member
There was a problem hiding this comment.
I think we should stick to the other function that we already use :)
Suggested change
| if (StringUtils.isNoneEmpty(getIamProfileName())) { | |
| if (StringUtils.isNotEmpty(getIamProfileName())) { |
| public void validate() { | ||
| // At most one of iamProfileCrn or iamProfileId may be specified. | ||
| if (StringUtils.isNotEmpty(getIamProfileCrn()) && StringUtils.isNotEmpty(getIamProfileId())) { | ||
| // At most one of iamProfileCrn or iamProfileI or iamProfileName may be specified. |
Member
There was a problem hiding this comment.
👀
Suggested change
| // At most one of iamProfileCrn or iamProfileI or iamProfileName may be specified. | |
| // At most one of iamProfileCrn or iamProfileId or iamProfileName may be specified. |
pyrooka
reviewed
Jul 15, 2026
| if (counter > 1) { | ||
| throw new IllegalArgumentException( | ||
| String.format(ERRORMSG_ATMOST_ONE_PROP_ERROR, "iamProfileCrn", "iamProfileId")); | ||
| String.format(ERRORMSG_ATMOST_ONE_PROP_ERROR, "iamProfileCrn", "iamProfileId", "iamProfileName")); |
Member
There was a problem hiding this comment.
One more thing: the ERRORMSG_ATMOST_ONE_PROP_ERROR constant should be updated to handle 3 arguments. Previously it was just 2.
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Jul 16, 2026
# [9.27.0](9.26.0...9.27.0) (2026-07-16) ### Features * **auth:** add new IAM profile selector to VPC Instance Auth ([#250](#250)) ([e9e0d22](e9e0d22))
Contributor
|
🎉 This PR is included in version 9.27.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds IAM Profile selector to the
VPC Instance Authenticator.