Skip to content

refactor: use closure-based result iteration#363

Merged
KKould merged 3 commits into
mainfrom
result-tuple-visitor-tpcc
Jun 22, 2026
Merged

refactor: use closure-based result iteration#363
KKould merged 3 commits into
mainfrom
result-tuple-visitor-tpcc

Conversation

@KKould

@KKould KKould commented Jun 21, 2026

Copy link
Copy Markdown
Member

Summary

  • make result iterators expose rows through a closure-based next_tuple API so callers can consume the executor tuple slot without the old owned-iterator path
  • update ORM/macros, shell, Python/WASM, storage tests, and TPCC backends to use the visitor-style result path where appropriate
  • remove the radix-sort branch and keep sort on the simpler comparison-based implementation
  • refresh TPCC benchmark documentation and bump crate versions to kite_sql 0.3.3 / kite_sql_serde_macros 0.2.3

Validation

  • cargo fmt --check
  • cargo metadata --format-version 1 --no-deps
  • git diff --check --cached
  • cargo test -p tpcc
  • make test-all

@KKould KKould force-pushed the result-tuple-visitor-tpcc branch from aff8b6e to 006333c Compare June 22, 2026 00:35
@KKould KKould force-pushed the result-tuple-visitor-tpcc branch from 006333c to dac3259 Compare June 22, 2026 00:42
@KKould KKould changed the title Refine tuple result iteration refactor: use closure-based result iteration Jun 22, 2026
KKould added 2 commits June 22, 2026 13:03
* Use space-saving counters for column TopN

* Fallback on high-error TopN estimates

* refactor(optimizer): remove unused ColumnTopN merge API
@KKould KKould added the enhancement New feature or request label Jun 22, 2026
@KKould KKould self-assigned this Jun 22, 2026
@KKould KKould merged commit 136ec3a into main Jun 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant