Fall back to unaligned pedigree plot when kinship2 alignment fails#1147
Open
labkey-martyp wants to merge 1 commit into
Open
Fall back to unaligned pedigree plot when kinship2 alignment fails#1147labkey-martyp wants to merge 1 commit into
labkey-martyp wants to merge 1 commit into
Conversation
kinship2's QP-based alignment (align=TRUE) can fail with "constraints are inconsistent, no solution!" on deep or looped pedigrees, which aborts the entire Pedigree report. Wrap the plot call in tryCatch so that this specific alignment failure is caught and retried with align=FALSE, letting the report render rather than error out. Any other error is re-raised unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
kinship2's QP-based alignment (align=TRUE) can fail with "constraints are inconsistent, no solution!" on deep or looped pedigrees, which aborts the entire Pedigree report so no image renders at all.
Related Pull Requests
None.
Changes
plot()call in the Pedigree report intryCatch, retrying once withalign=FALSEwhen the alignment error is detected so the report still renders. Any other error is re-raised unchanged.